Reject stale completed one-head nanoGPT runs - #41
Merged
Conversation
charlesmartin14
marked this pull request as ready for review
August 9, 2026 21:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The one-head nanoGPT runner treated the existence of
run_complete.jsonas sufficient proof that a result could be reused. That shortcut ran before the current prepared-data identity and protocol fingerprint were calculated.run_is_complete()likewise checked onlycompleted: true.A stale directory from an older protocol, different prepared corpus, changed optimizer profile, changed model/training configuration, or missing terminal artifact could therefore be silently accepted.
Changes
run_is_complete()use artifact validation instead of trusting a Boolean markerBehavior
A compatible and complete result is reused without initializing the training device or model. A stale, incomplete, corrupt, or ambiguous result fails explicitly and instructs the caller to use a new result directory or rerun with explicit overwrite. Existing artifacts are never silently replaced.
Validation
git diff --checkpython -m compileall -q baseline/nanogpt_one_head/src baseline/nanogpt_one_head/testspytest -q baseline/nanogpt_one_head/tests— 17 passedpip check— no broken requirementsNo optimizer mathematics, hyperparameters, model architecture, notebook source, committed output notebook, or experiment result was changed. This PR is independent of PR #40.