fix(persona): always-record persona turns including failures#1082
Merged
Conversation
… fixtures Three integration test files (persona_respond_replay, vision_integration, fixture_assembly_replay) constructed RespondInput/PersonaContext literals without the other_persona_names field that was added to those structs in PR #950 (2c31cc2). The fixtures wouldn't compile, blocking the cargo --tests build path. Defensive follow-up to 41aee0c (move prompt capture to rust recorder): the recorder commit lands cleanly on cargo test --lib (1922/0), but the broader test build was already broken on canary by the field-add drift. This commit fixes only the field omission; pre-existing format-string + SamplingConfig API drift in qwen35_live_pipeline_diff and persona_prompt_token_diagnostic remain (separate PR scope). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 11, 2026
joelteply
added a commit
that referenced
this pull request
May 11, 2026
…ft) (#1086) Three pre-existing canary breakages in integration tests blocked the broader cargo --tests build, hiding any other regression that might land. Fixes are mechanical and isolated to test fixtures: - llamacpp_metal_throughput.rs / qwen35_live_pipeline_diff.rs: backend .generate(...) signature took `temperature: f64` until the SamplingConfig refactor; tests still passed `0.0` / `0.7`. Updated to SamplingConfig literal (qwen35: explicit greedy, no repeat_penalty so output matches the bare-decode reference) and SamplingConfig::chat() (throughput: matches what live chat traffic uses). - persona_prompt_token_diagnostic.rs: format string `"{model_path()}"` uses Rust 2024 captured-identifier syntax which doesn't allow function calls — emits "expected `}`, found `(`" at compile time. Bound to a local + use positional `{}` with `path.display()`. Same scope as the test-fixture follow-up in 98a6c91 (other_persona_names field add). Was flagged as out-of-scope in PR #1082's "Known gaps" — now it can come off that list. Pre-push hook still passes (cargo test --lib unaffected; this only restores `cargo build --tests` and `cargo test <integration>`). Co-authored-by: Test <test@test.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per RTX (continuum-8e97)'s #1068 review finding: `record_turn()` at response.rs:273 only fired on the `Ok`-path of `respond()`. If `respond()` returned `Err` (analyze fail, render fail, any internal `?` propagation), NO fixture landed on disk — direct contradiction of recorder.rs's F1-telemetry header ("F1 cars don't ship without telemetry") and Joel's "evidence is for the debugger, not the trash" rule. The most diagnostic turns (the failures) left zero trail.
What changed
Validation class
Validation
Three-way convergence
Known gaps