test: unblock cargo --tests build (SamplingConfig + format string drift)#1086
Merged
Conversation
Three pre-existing canary breakages in integration tests blocked the
broader cargo --tests build, hiding any other regression that might
land. Fixes are mechanical and isolated to test fixtures:
- llamacpp_metal_throughput.rs / qwen35_live_pipeline_diff.rs: backend
.generate(...) signature took `temperature: f64` until the SamplingConfig
refactor; tests still passed `0.0` / `0.7`. Updated to SamplingConfig
literal (qwen35: explicit greedy, no repeat_penalty so output matches
the bare-decode reference) and SamplingConfig::chat() (throughput:
matches what live chat traffic uses).
- persona_prompt_token_diagnostic.rs: format string `"{model_path()}"`
uses Rust 2024 captured-identifier syntax which doesn't allow function
calls — emits "expected `}`, found `(`" at compile time. Bound to a
local + use positional `{}` with `path.display()`.
Same scope as the test-fixture follow-up in 98a6c91 (other_persona_names
field add). Was flagged as out-of-scope in PR #1082's "Known gaps" — now
it can come off that list. Pre-push hook still passes (cargo test --lib
unaffected; this only restores `cargo build --tests` and `cargo test
<integration>`).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three pre-existing canary breakages blocked the broader `cargo --tests` build path. These were flagged as out-of-scope in PR #1082's "Known gaps"; cleared here so the integration test build stays compilable going forward (and so regressions in any test file can land in CI signal instead of being masked behind "build broken" silence).
Validation class
Validation
Scope discipline
This is a test-fixture-only cleanup — three files, all under `tests/`. No production source touched. Cleared from PR #1082's Known-Gaps list.