chore(cognition): dead-wire + doc hygiene from the citizenship audit (#428) - #2300
Merged
Merged
Conversation
…428) Three fixes, no behavior change on any live path: 1. Delete the orphan agent:solve:complete publish (solve.rs). Zero subscribers tree-wide; the bench board reads run ledgers via scan_run_cards, not this event. Dead wire on the detached-runner path #425 will retire. 2. Correct the stale service_loop.rs turn-servicing comment. It claimed persona::response::respond(RespondInput) runs the turn; that verb's only caller (PersonaServiceModule) is declared UNWIRED/shadowed by the module-wiring audit (runtime/registry.rs). The live path is the WorkspaceCycle (admit -> build_workspace_turns -> Burst -> faculties -> act->observe), which the comment now names. 3. PERSONA-COGNITION-PIPELINE.md paragraph 2: add a per-verb Status column. Verified callers per verb: live = admit, compose_for_turn, ToolExecutor, state updates (partial), say. Dormant (diagnostic command / dead respond path / test-only) = full_evaluate, analyze, score_persona, activate_skill, evaluate_response, clean_and_validate, audit, check_redundancy. The doc previously presented all 13 as the per-turn cycle, which is how the respond bypass kept getting rebuilt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LoTjvf5j3Ez13g6k8mRkFo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three hygiene fixes from the 2026-08-14 citizenship audit (AXIS 3, drift items). No behavior change on any live path.
Orphan event deleted:
agent:solve:complete(solve.rs) had zero subscribers tree-wide. The bench board reads run ledgers viascan_run_cards(and now reaches citizen perception via the ViewState pipe, feat(cognition): bind the benchmark board to citizen eyes — BenchViewState via the ViewState pipe (#426) #2298); the event was dead wire on the detached-runner path that Gap analysis: 49 open issues, 20 closed #425 will retire.Stale comment corrected (service_loop.rs): claimed the turn is serviced through
persona::response::respond(RespondInput). That verb's only caller,PersonaServiceModule, is declared UNWIRED/shadowed by the module-wiring audit (runtime/registry.rs). The comment now names the real live path — the WorkspaceCycle (admit → build_workspace_turns → Burst → faculties → act→observe).PERSONA-COGNITION-PIPELINE.md §2 gets a Status column: the 13-verb table previously presented all verbs as the live per-turn cycle. Verified per-verb (grep for production callers): live = admit, compose_for_turn, ToolExecutor, state updates (partial), say. Dormant (diagnostic-command-only / dead respond path / test-only) = full_evaluate, analyze, score_persona, activate_skill, evaluate_response, clean_and_validate, audit, check_redundancy. "Dormant" is explicitly defined as reuse-don't-parallel.
Why
The doc drift is how the respond bypass kept getting rebuilt under amnesia — the doc said those verbs run per-turn, so new code kept wiring against them. Task #428.
Validation
cargo check -p continuum-core --features metal,accelerateclean (1m18s). The only code changes are a 5-line dead publish removal and a comment.🤖 Generated with Claude Code
https://claude.ai/code/session_01LoTjvf5j3Ez13g6k8mRkFo