Chore/mypy quarantine v0.5.1 - #19
Merged
Merged
Conversation
…ped_defs ratchet; bump 0.5.1 B1: built a CPU-torch parity venv mirroring the CI types job (torch CPU + .[dev] -c constraints.txt) to reproduce CI's mypy view locally, then cleared all 12 quarantined modules to zero (95→0, env-invariant — parity venv AND local nightly-torch both green). Removed the entire `ignore_errors` override. The torch-stub batch diverges by error CODE across torch builds (nightly attr-defined vs CPU-torch operator/return-value), so any coded `# type: ignore` is unused in one env under warn_unused_ignores. Fixed env-invariantly: wrapped- module / DeepSpeed-engine methods via `cast(Any, model).m(...)`; layer iterators and ArchitectureProfile lambdas via `cast(Any, m).attr`; stateful `self._state` narrowed with `assert ... is not None`; trainer `self.model: Any | None` consumers asserted; artifact-store header/root/finalize (on the concrete ArtifactStoreBase / subclass, not the read protocol) via targeted casts. B2: enabled `check_untyped_defs = true`. The whole lighttrain/ package passes with untyped bodies checked (0 new errors, incl. the 12 un-quarantined modules); the ~358 untyped-body errors are all in tests/, opted out via a new `tests.*` override (the next ratchet target). asserts only restate existing invariants — zero runtime behavior change. CanGeng
…KNOWN_ISSUES tombstone New docs/changelog/v0/v0.5/v0.5.1.md documents the CPU-torch parity-venv methodology, the B1 12→0 quarantine clear, and the B2 check_untyped_defs ratchet. KNOWN_ISSUES.md: B1 moved to a one-line tombstone (→ v0.5.1); B2 updated to reflect production fully checked with tests/ remainder as the next ratchet target. CanGeng
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.