fix(connector): use public strip_trailing_semicolon in dry_run paths - #2550
Conversation
Main still calls the old private alias _strip_trailing_semicolon in DataFusion and Snowflake dry_run after the helper was renamed/exported as strip_trailing_semicolon on base. That completes as NameError/F821 on every PR merge against main (lint + unit). Point both call sites at the imported public helper.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughDataFusion and Snowflake dry-run methods now use ChangesSQL normalization
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks @Bartok9 |
Summary
maincurrently importsstrip_trailing_semicolonbut still calls_strip_trailing_semicoloninDataFusionConnector.dry_runandSnowflakeConnector.dry_run.NameErroron every fresh PR merge queue check (seen on fix(engine): skip non-dict models/views when collecting names #2546–fix(dbt): skip unusable models/columns in seed payloads #2549).Test plan
Summary by CodeRabbit