Skip to content

Prevent inadvertent submodule downgrades - #2171

Open
speth wants to merge 2 commits into
Cantera:mainfrom
speth:fix-2170-yaml-cpp-submodule
Open

Prevent inadvertent submodule downgrades#2171
speth wants to merge 2 commits into
Cantera:mainfrom
speth:fix-2170-yaml-cpp-submodule

Conversation

@speth

@speth speth commented Sep 3, 2026

Copy link
Copy Markdown
Member

Changes proposed in this pull request

  • Restore yaml-cpp submodule to version 0.9.0
  • Add a CI job to ensure that submodule downgrades are flagged as an error

If applicable, fill in the issue number this pull request is fixing

Closes #2170

Example usage

I initially opened this PR with a commit downgrading the googletest submodule. The new CI job fails and provides the following log messages:

image

AI Statement (required)

  • Extensive use of generative AI. Significant portions of code or documentation were generated with AI, including
    logic and implementation decisions. All generated code and documentation were reviewed and understood by the contributor. Implemented using Claude Sonnet 5.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • AI Statement is included
  • The pull request is ready for review

speth and others added 2 commits September 3, 2026 17:36
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@speth speth added the CI label Sep 3, 2026
@speth
speth force-pushed the fix-2170-yaml-cpp-submodule branch from 16ec6d0 to e384a44 Compare September 3, 2026 21:56
@speth
speth marked this pull request as ready for review September 3, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit 520487d has downgraded yaml-cpp submodule.

2 participants