Skip to content

[codex] Fix dashboard chart height#2035

Merged
riderx merged 1 commit into
mainfrom
codex/fix-dashboard-chart-height
May 6, 2026
Merged

[codex] Fix dashboard chart height#2035
riderx merged 1 commit into
mainfrom
codex/fix-dashboard-chart-height

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented May 6, 2026

Summary (AI generated)

  • Restored the shared dashboard chart card to a fixed 460px height.
  • Added min-h-0 to the chart content area so Chart.js canvases can use the available card space.

Motivation (AI generated)

The refreshed dashboard design changed chart cards to a minimum height, which let the onboarding trend canvas render short while the card kept large empty space.

Business Impact (AI generated)

This keeps admin analytics charts readable and preserves the refreshed dashboard layout without wasting visual space.

Test Plan (AI generated)

  • Run bun lint
  • Run bun typecheck
  • Verify the local Vite app loads headlessly at /admin/dashboard/users?page=1

Generated with AI

Summary by CodeRabbit

  • Style
    • Updated chart card layout with fixed height container and improved inner content spacing for better visual consistency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0a7d3218-6d95-4509-ac7b-82b1ca300004

📥 Commits

Reviewing files that changed from the base of the PR and between 7c08f68 and a9aa0b1.

📒 Files selected for processing (1)
  • src/components/dashboard/ChartCard.vue

📝 Walkthrough

Walkthrough

ChartCard.vue outer container height changed from a minimum-height utility to fixed-height utility; inner chart content area adds a min-height-zero constraint. Layout-only modifications with no API, behavior, or logic changes.

Changes

Chart Card Layout Adjustment

Layer / File(s) Summary
Styling Update
src/components/dashboard/ChartCard.vue
Outer container switches from min-height baseline to fixed height; inner chart content div adds min-h-0 constraint for proper content area sizing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, some CSS tweaks,
The ChartCard wears its new physique,
Heights adjusted, min-constraints in place,
Yet no behavior shifts its graceful pace!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[codex] Fix dashboard chart height' directly and clearly describes the main change: fixing dashboard chart height issues in ChartCard.vue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-dashboard-chart-height

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented May 6, 2026

Merging this PR will not alter performance

✅ 28 untouched benchmarks


Comparing codex/fix-dashboard-chart-height (a9aa0b1) with main (7c08f68)

Open in CodSpeed

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@riderx riderx marked this pull request as ready for review May 6, 2026 10:31
@riderx riderx merged commit 5b76c59 into main May 6, 2026
38 checks passed
@riderx riderx deleted the codex/fix-dashboard-chart-height branch May 6, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant