Fix dashboard stats card overflow#2261
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR improves responsive layout behavior in two dashboard chart components. ChartCard receives flex constraints ( ChangesDashboard Responsive Layout Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@Stevenn28 I opened the PR for you. #2243 |
Merging this PR will degrade performance by 48.16%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | /updates manifest response with metadata |
120.3 µs | 232.1 µs | -48.16% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Stevenn28:codex/fix-stat-card-overflow (0562f76) with main (1e90612)
Footnotes
-
2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
|
The failing
Those strings are not present on current |
KCDaemon
left a comment
There was a problem hiding this comment.
Reviewed the changed dashboard card layout classes in ChartCard.vue and UpdateStatsCard.vue. The flex/min-width/shrink changes are narrowly scoped to the overflow issue, and they preserve the existing chart/card structure while allowing long totals and legend values to wrap instead of forcing horizontal overflow.\n\nI do not see a blocker in the changed Vue files. The red Run tests job appears unrelated to this PR's touched files: it fails in the typos step on backend strings that are not part of this diff, as noted in the existing thread. CodSpeed also reports a benchmark regression, but this patch only changes Vue/Tailwind classes; that result looks like a noisy comparison rather than a runtime consequence of these two component changes.



Summary by CodeRabbit
Release Notes