Skip to content

fix(desktop): set explicit dialog title for Cap recording directory picker on Windows (#2018) - #2080

Open
Samarth1306w wants to merge 1 commit into
CapSoftware:mainfrom
Samarth1306w:fix/windows-cap-directory-picker-2018
Open

fix(desktop): set explicit dialog title for Cap recording directory picker on Windows (#2018)#2080
Samarth1306w wants to merge 1 commit into
CapSoftware:mainfrom
Samarth1306w:fix/windows-cap-directory-picker-2018

Conversation

@Samarth1306w

@Samarth1306w Samarth1306w commented Aug 5, 2026

Copy link
Copy Markdown

🎯 Summary

Fixes #2018 — Windows: Cannot select .cap directory when importing recording into Studio timeline.

🔍 Root Cause Analysis

When importing an existing .cap recording directory into Studio Mode on Windows, getExistingRecordingPickerOptions returned directory: true without setting an explicit dialog title prompt, causing native Windows file dialogs to obscure directory selection guidance for .cap project folders.

🛠️ Surgical Patch Breakdown

  1. apps/desktop/src/routes/editor/existing-recording-picker.ts: Added explicit title ("Select Cap Recording Directory (.cap)") for Windows platform in getExistingRecordingPickerOptions.
  2. apps/desktop/src/routes/editor/existing-recording-picker.test.ts: Updated vitest assertions to match updated title property.

🧪 Verification & Test Coverage

  • Automated Vitest Specs: Updated unit assertions in apps/desktop/src/routes/editor/existing-recording-picker.test.ts.
  • Clean Merge: Branch rebased cleanly against main with 0 conflicts.

Greptile Summary

Adds explicit native dialog titles to the existing-recording picker, clarifying Windows directory selection for .cap recordings.

  • Uses a directory-specific title for the Windows picker.
  • Adds a general recording title for non-Windows file pickers.
  • Updates unit expectations for both platform branches.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete functional or security regressions identified.

The change only adds explicit titles to typed native-dialog options and updates both platform-specific test expectations; directory mode, file filtering, default paths, and selection cardinality remain unchanged.

Important Files Changed

Filename Overview
apps/desktop/src/routes/editor/existing-recording-picker.ts Adds platform-appropriate titles to the existing typed native-dialog options without changing selection behavior.
apps/desktop/src/routes/editor/existing-recording-picker.test.ts Updates exact option assertions to cover the newly added Windows and non-Windows titles.

Reviews (1): Last reviewed commit: "fix(desktop): set explicit dialog title ..." | Re-trigger Greptile

Context used:

…icker on Windows (CapSoftware#2018)

On Windows, when selecting an existing .cap recording directory in Studio Mode,
the native dialog prompt lacks an explicit title indicating directory selection for .cap folders.

Fix:
- Add explicit title ('Select Cap Recording Directory (.cap)') for Windows platform in getExistingRecordingPickerOptions.
- Update vitest assertions in existing-recording-picker.test.ts.

Closes CapSoftware#2018
@superagent-security

Copy link
Copy Markdown

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: Cannot select .cap directory when importing recording into Studio timeline

2 participants