Skip to content

Fix Turbopack whole-project tracing from ffmpeg spawn calls #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richiemcilroy merged 1 commit into from
Aug 14, 2026
+15 −7
Merged

Fix Turbopack whole-project tracing from ffmpeg spawn calls #2125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions apps/web/lib/audio-extract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ export async function extractAudioFromUrl(
];

return new Promise((resolve, reject) => {
const proc = spawn(ffmpeg, ffmpegArgs, { stdio: ["pipe", "pipe", "pipe"] });
const proc = spawn(/*turbopackIgnore: true*/ ffmpeg, ffmpegArgs, {
stdio: ["pipe", "pipe", "pipe"],
});

let stderr = "";

Expand Down Expand Up @@ -124,7 +126,9 @@ export async function extractAudioToBuffer(videoUrl: string): Promise<Buffer> {
];

return new Promise((resolve, reject) => {
const proc = spawn(ffmpeg, ffmpegArgs, { stdio: ["pipe", "pipe", "pipe"] });
const proc = spawn(/*turbopackIgnore: true*/ ffmpeg, ffmpegArgs, {
stdio: ["pipe", "pipe", "pipe"],
});

const chunks: Buffer[] = [];
let stderr = "";
Expand Down Expand Up @@ -168,7 +172,9 @@ export async function convertWavToMp3(wavBuffer: Buffer): Promise<Buffer> {
];

return new Promise((resolve, reject) => {
const proc = spawn(ffmpeg, ffmpegArgs, { stdio: ["pipe", "pipe", "pipe"] });
const proc = spawn(/*turbopackIgnore: true*/ ffmpeg, ffmpegArgs, {
stdio: ["pipe", "pipe", "pipe"],
});

const chunks: Buffer[] = [];
let stderr = "";
Expand Down Expand Up @@ -216,7 +222,7 @@ export async function checkHasAudioTrack(videoUrl: string): Promise<boolean> {
const ffmpegArgs = ["-i", videoUrl, "-hide_banner"];

return new Promise((resolve, reject) => {
const proc = spawn(ffmpeg, ffmpegArgs, {
const proc = spawn(/*turbopackIgnore: true*/ ffmpeg, ffmpegArgs, {
stdio: ["pipe", "pipe", "pipe"],
});

Expand Down
2 changes: 1 addition & 1 deletion apps/web/lib/og/poster-frame.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const grabFrame = (
) =>
new Promise<Buffer>((resolve, reject) => {
const proc = spawn(
ffmpeg,
/*turbopackIgnore: true*/ ffmpeg,
[
"-hide_banner",
"-loglevel",
Expand Down
6 changes: 4 additions & 2 deletions apps/web/lib/video-convert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ function runFfmpeg(args: string[]): Promise<void> {
const ffmpeg = getFfmpegPath();

return new Promise((resolve, reject) => {
const proc = spawn(ffmpeg, args, { stdio: ["ignore", "ignore", "pipe"] });
const proc = spawn(/*turbopackIgnore: true*/ ffmpeg, args, {
stdio: ["ignore", "ignore", "pipe"],
});

let stderr = "";

Expand Down Expand Up @@ -270,7 +272,7 @@ export async function convertRemoteVideoToMp4Buffer(
const result = await convertRemoteVideoToMp4(videoUrl);

try {
return await fs.readFile(result.filePath);
return await fs.readFile(/*turbopackIgnore: true*/ result.filePath);
} finally {
await result.cleanup();
}
Expand Down
Loading