Highlight server warnings in multiplayer chat#10437
Open
MostCromulent wants to merge 2 commits intoCard-Forge:masterfrom
Open
Highlight server warnings in multiplayer chat#10437MostCromulent wants to merge 2 commits intoCard-Forge:masterfrom
MostCromulent wants to merge 2 commits intoCard-Forge:masterfrom
Conversation
Adds a WARNING ChatMessage.MessageType, rendered as amber foreground text on desktop (FNetOverlay) and an amber bubble background on mobile (ChatMessageBubble), distinct from the existing blue system and default player styles. Tagged call sites in FServerManager (all session/connection health): - UPnP port mapping failure (success path stays blue) - Heartbeat timeout forcing disconnect - Initial disconnect + reconnect-waiting notice - Forge version null/mismatch warnings - "Did not reconnect in time, AI takeover" MessageEvent gains a nullable type field with serialVersionUID unchanged, so old and new clients continue to interoperate. Pre-WARNING-tag senders deserialize as null; MessageEvent.getType() normalizes to SYSTEM/PLAYER based on source, so receivers never see null. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
22 tasks
MessageEvent: store type as String not enum — unknown enum constants cause InvalidObjectException on older clients even for skipped fields. Remove ILobbyListener default overload, dead isSystemMessage(), inline imports in test files, trailing periods on comments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MostCromulent
force-pushed
the
NetworkPlay/chat-warnings
branch
from
10ac5f5 to
23eac9f
Compare
tool4ever
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WARNINGChatMessage.MessageTyperendered amber on desktop (foreground) and mobile (bubble background), distinct from blue system / default player styles. Amber chosen over red for legibility on both light and dark themes.FServerManager: UPnP failure, heartbeat timeout, disconnect notice, version mismatch, "did not reconnect in time".MessageEvent.typeis stored asString(not enum) for serialization safety — unknown enum constants causeInvalidObjectExceptionon older clients even when skipping fields the old class doesn't declare.getType()converts back to enum with fallback toSYSTEMfor unrecognized values.🤖 Generated with Claude Code