Revert "Check meld "zone" when generating snapshots" - #11426
Merged
Conversation
This reverts commit f438749.
Contributor
|
Somewhat related to #11058 too |
Contributor
|
I wish to (re)move the Battlefield.meldedCards property too, but that might be something for later |
Hanmac
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9572
We cannot have this method simply return the secondary meld halfs all the time.⚠️
It's used everywhere to obtain the real boardstate,
ReplacementHandleretc.So there's a medium risk we'd be using traits that don't exist in the game currently
This changes it so it's more aligned with the logic introduced by #11401
Together with #11421 everything should then be fine....