AttachAi: make KeepTapped logic generic

[Hanmac]

with that we should be able to remove the "KeepTapped" logic from the Auras

[Agetian]

Good idea! 👍

[tool4ever]

LGTM

[Hanmac]

@tool4ever do you want to remove the KeepTapped Flag on the Cards with this MR or another one?

[tool4ever]

should be done together imo

[Hanmac]

@tool4ever hm there is one of them that isn't a spell:

forge/forge-gui/res/cardsfolder/s/stasis_cell.txt

Line 7 in 2042aaa

A:AB$ Attach | Cost$ 3 U | ValidTgts$ Creature | TgtPrompt$ Select target creature | AILogic$ KeepTapped | SpellDescription$ Attach CARDNAME to target creature.

Maybe I should remove the isAuraSpell check?

[tool4ever]

it's probably RemoveDeck because of that anyway 🤷‍♂️

[Hanmac]

@tool4ever can you update the cards for me in this MR, or should i do that later?

[tool4ever]

maybe on the weekend but not near my IDE right now

[Hanmac]

@tool4ever
Hm apropos attach, we might need to separate the logic between such Auras that keep stuff tapped,
and Equipment like Cement Shoes that does have it as drawback.

i will think about the second ones if they need some extra logic

[Hanmac]

@tool4ever @Agetian i think this is ready?
i will do the Equipments on a later day