Skip to content

Remove @types/dompurify#641

Merged
lynnfaraday merged 4 commits into
mainfrom
linda/remove-types-dompurify
Jul 22, 2026
Merged

Remove @types/dompurify#641
lynnfaraday merged 4 commits into
mainfrom
linda/remove-types-dompurify

Conversation

@lynnfaraday

@lynnfaraday lynnfaraday commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Overview

I was checking out #631 and realized that @types/dompurify has been deprecated. Its NPMJS note says:

This is a stub types definition. dompurify provides its own type definitions, so you do not need this installed.

Everything appears to work with it removed.

Also bumped dompurify's version per #637.

Security

Consider potential security impacts and complete the following checklist.
REMINDER: All file contents are public.

  • I have ensured no secure credentials or sensitive information remain in code, metadata, comments, etc.
    • Please verify that you double checked that .storybook/preview.js does not contain your participant access key details.
    • There are no temporary testing changes committed such as API base URLs, access tokens, print/log statements, etc.
  • These changes do not introduce any security risks, or any such risks have been properly mitigated.

Testing

Consider whether the changes might have device-specific behaviors (screen padding, new APIs, etc.) and check one of the following boxes:

  • This change can be adequately tested using the MDH Storybook.
  • This change requires additional testing in the MDH iOS/Android/Web apps. (Create a pre-release tag/build and test in a ViewBuilder PR.)

Storybook smoke testing, including checking out the XSS story in ReportContent (which is the place dompurify is directly used)

Documentation

Consider whether there are any documentation impacts and check one of the following boxes:

  • I have added relevant Storybook updates to this PR.
  • If this feature requires a developer doc update, I have tagged @CareEvolution/api-docs.
  • This change does not impact documentation or Storybook.

Reviewers

Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including:

  • Subject-matter experts
  • Style/editing reviewers
  • Others requested by the content owner

Consider "Squash and merge" as needed to keep the commit history reasonable on main.

dependabot Bot and others added 3 commits July 14, 2026 00:04
Bumps [@types/dompurify](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/dompurify) from 3.0.5 to 3.2.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/dompurify)

---
updated-dependencies:
- dependency-name: "@types/dompurify"
  dependency-version: 3.2.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@lynnfaraday
lynnfaraday requested a review from greinard July 22, 2026 12:45
@aws-amplify-us-east-1

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-641.d1xp2kmk6zrv44.amplifyapp.com

@greinard greinard left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@lynnfaraday
lynnfaraday merged commit 300213e into main Jul 22, 2026
8 checks passed
@lynnfaraday
lynnfaraday deleted the linda/remove-types-dompurify branch July 22, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants