Parsing incorrect if number text has thousands separator(s)

[nietras]

I was not aware of this, but it appears csFastFloat does not parse numbers correctly if text has thousands separators? Is that not handled in fast_float? The test fails for "1,234,567.89" with:

Assert.Equal() Failure
Expected: 1234567.9
Actual:   1

[nietras]

another issue is that whitespace characters are not counted towards characters consumed, not sure if reason for not doing this?

    internal unsafe static bool TryParseNumber(char* first, char* last, out int characters_consumed, out float result, NumberStyles styles = NumberStyles.Float, char decimal_separator = '.')
    {
        characters_consumed = 0;
        result = 0f;
        while (first != last && Utils.is_ascii_space(*first))
        {
            first++;
        }

        if (first == last)
        {
            result = 0f;
            characters_consumed = 0;
            return false;
        }

first moved is later not added to characters consumed

[lemire]

Thanks. I’ll have a look.

I do not expect thousand separators to work: I don’t think that it was ever was advertised.

[nietras]

I do not expect thousand separators to work: I don’t think that it was ever was advertised.

No it isn't, however I made the mistake of thinking this meant parsing would fail/return false for case with such characters in text, I have changed to check consumed chars and if text contains thousand separators.