Skip to content

Parsing incorrect if number text has thousands separator(s) #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nietras wants to merge 1 commit into from
Closed

Parsing incorrect if number text has thousands separator(s) #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions TestcsFastFloat/Basic/TestFloatParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using csFastFloat.Structures;
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Text;
using Xunit;

Expand All @@ -22,6 +23,18 @@ public class TestFloatParser : BaseTestClass
{ "-infinity", float.NegativeInfinity }
};

[Fact]
unsafe public void FastFloatParser_ThousandSeparator()
{
var culture = CultureInfo.InvariantCulture;
var input = "1,234,567.89";
fixed (char* p = input)
{
var bcl = float.Parse(input, culture);
var csff = FastFloatParser.ParseFloat(input);
Assert.Equal(bcl, csff);
}
}

[Trait("Category", "Smoke Test")]
[Theory]
Expand Down
Loading