add missing test checks to jenkins, remove commit tests#2508
Closed
danoswaltCL wants to merge 9 commits intodevfrom
Closed
add missing test checks to jenkins, remove commit tests#2508danoswaltCL wants to merge 9 commits intodevfrom
danoswaltCL wants to merge 9 commits intodevfrom
Conversation
Collaborator
Author
|
hm, do i see the frontend test showing up, and one of my commits to test the backend failed but now I don't see the job showing up, may be missing something about how it works for backend. |
Collaborator
Author
|
#2639 this one is what we went with instead of this, so closiing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't really refine this or chat much about this story but we have failing tests on
devand all i wanted to do was put up the PR to bump version to 6.2.This adds missing test scripts as PR checks for backend and frontend, as well as typecheck.
I also removed the tests from the precommit hook because they are redundant if we are doing them as a PR check, and they are quite annoying to always run. Rather than "fix" them to only run on relevant project changes, I just left the linter check, which silently fixes things and does run only on relevant changes, that seems ok but I'm open to what else may want to do.
@shpwe @kcalvo-cli let me know if this is the proper way to go about this in Jenkinsfile.