Conversation
Update for Xcode 7 Beta 5
There was a problem hiding this comment.
Should we also enforce ClientError conform to ErrorType?
|
This is neat, @neilpa! There's already a Swift 2 branch at One of us should merge in improvements from the other branch. You or me, I'm happy either way! |
|
D'oh, I didn't look beyond open PRs before starting these changes. Otherwise I would've built on top of your existing branch. I'll rebase this against the existing branch later today. |
|
@jpsim Merged your changes into here as well. |
Thanks! Could you change |
There was a problem hiding this comment.
This should actually be split(2, ... as explained in #30.
There was a problem hiding this comment.
They must've changed it back because I didn't see any failures locally when running the tests.
There was a problem hiding this comment.
Oh, that's entirely possible.
|
Once CI is back up (and passing), this is good to go! Thanks @neilpa! |
|
It looks like CI is failing because |
|
Lets try this again. |
|
Not sure why the tests aren't running on travis |
|
It seems that we need xctool 0.2.6 and Quick/Quick#388. |
There was a problem hiding this comment.
This xcscmblueprint file should probably be removed and ignored. 👆
This reverts commit 72d8863.
[Swift 2] Update Quick to work with xctool
|
The tests are passed now on this branch. 🎉 |
|
Looks good to me! |
|
Actually, I think the Components.plist needs to be updated now that Box is now longer used. |
There was a problem hiding this comment.
Quick/Quick#388 is not included in the latest release.
|
This looks good to me apart from the concerns about the |
Is that the Carthage's one? |
|
Since the upstream dependencies haven't had releases yet, I'm good to merge this. But we should be sure to get updated releases for those dependencies before doing a Commandant release. |
|
Thanks for all the hard work everyone! 💖 |
|
👏 |
No description provided.