Naively ported to Swift 2.0#26
Naively ported to Swift 2.0#26jpsim wants to merge 2 commits intoCarthage:masterfrom jpsim:swift-2.0
Conversation
There was a problem hiding this comment.
Maybe we should remove the external label on the second parameter instead. I don’t have a strong opinion other than to note that usage is perhaps not a terribly helpful external label.
|
@jpsim Thanks for taking this on! ✨ I'd like However, since it will probably be useful to bring in these changes (for SourceKitten, at the very least), I think maintaining a branch with Swift 2 support would be 💎. To that end, I've added you as a collaborator—feel free to push your branch to the main repo. 🙇 |
|
Makes total sense, I won't be merging Swift 2 support in my own repos until it goes GM either. I'll push up this branch soon. Thanks for the invite! |
Biggest changes here are:
BoxPrintable->CustomStringConvertible