Skip to content

Naively ported to Swift 2.0#26

Closed
jpsim wants to merge 2 commits intoCarthage:masterfrom
jpsim:swift-2.0
Closed

Naively ported to Swift 2.0#26
jpsim wants to merge 2 commits intoCarthage:masterfrom
jpsim:swift-2.0

Conversation

@jpsim
Copy link
Copy Markdown
Contributor

@jpsim jpsim commented Jun 14, 2015

Biggest changes here are:

  1. No longer needs to Box
  2. Swapped protocol free-functions to the new stdlib's protocol extension versions
  3. Printable -> CustomStringConvertible

Comment thread Commandant/Switch.swift
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove the external label on the second parameter instead. I don’t have a strong opinion other than to note that usage is perhaps not a terribly helpful external label.

@jspahrsummers
Copy link
Copy Markdown
Member

@jpsim Thanks for taking this on! ✨

I'd like master to match the latest production version of Swift, so I don't think we want to pull this PR in as-is.

However, since it will probably be useful to bring in these changes (for SourceKitten, at the very least), I think maintaining a branch with Swift 2 support would be 💎. To that end, I've added you as a collaborator—feel free to push your branch to the main repo. 🙇

@jpsim
Copy link
Copy Markdown
Contributor Author

jpsim commented Jun 16, 2015

Makes total sense, I won't be merging Swift 2 support in my own repos until it goes GM either. I'll push up this branch soon. Thanks for the invite!

@jpsim jpsim mentioned this pull request Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants