Conversation
- Make `ClientError`s conform to `ErrorType` - Parse options from `OptionsType`s automatically - Change `CommandType.run()` to take `Options` - Add `AnyCommand.usage()`
Member
Author
|
You can see how these changes affect Carthage in Carthage/Carthage#987. |
Member
|
I've tried the similar way and I couldn't reach to the goal at that time. 👏 I really like the idea, but I understand the @NachoSoto's concern that
Since |
Member
Author
|
I renamed |
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
I think we should eventually move this to Result so that RAC and this can share it /cc @robrix
Member
|
Looks good! ✨ I added some minor fixes and I'm gonna merge this. 💣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces some breaking changes to try to simplify the interaction of
CommandTypeandOptionsType:typealias Options: OptionsTypetoCommandTypeClientErrors conform toErrorTypeOptionsTypes automaticallyCommandType.run()to takeOptionsinstead ofCommandModeAnyCommandconform toCommandTypeAnyCommand.usage()This would greatly simplify something like #40 because options are no longer parsed by commands. It also removes a decent amount of boilerplate from commands.