Conversation
69d1582 to
42b902e
Compare
This finishes the work started years ago in 777b7f2 It adds a fair amount of complexity, but it allows for routes to preserve transforms which got broken when changing the route behaviour in 2.2
42b902e to
e9d3d67
Compare
jpc0
pushed a commit
to jpc0/server
that referenced
this pull request
Jun 27, 2025
This finishes the work started years ago in 777b7f2 It adds a fair amount of complexity, but it allows for routes to preserve transforms which got broken when changing the route behaviour in 2.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a fair amount of complexity in calculations, but it allows for routes to preserve transforms which got broken when changing the route behaviour in 2.2. closes #1307 #1274
This finishes the work started years ago in 777b7f2
Unless anyone has any objections, I shall aim to merge this to 2.5 soon.
I still need to reenable/reimplement the scale_modes, but this is otherwise looking functional and pretty complete.This is a slightly breaking change, as the way that crops compound now is slightly different. This should only affect routing one channel into another, where the crop values to be used on that routed frame are relative to the viewport and not the content. (This does sound wrong, could that change?) And also when routing a channel, the clip values for each layer are now respected correctly and may need to be set over amcp to avoid clipping the routed frame. While annoying, this is how it behaved before 2.2, so is consistent with behaviour when routes preserved transforms.
The other simple 'fix' for avoiding unexpected clips is to not scale beyond the channel bounds of the source channel, likely using a custom resolution channel to do so.
The one bit of this change that I do not like is the
enable_geometry_modifiersproperty, but that became necessary to avoid cropping on intermediary frames with no way to control it. The other option I can see is to entirely change how we do cropping, but that is a much larger and more breaking change