Pin phpbrake to 0.8.0 for PHP 8.0 compatibility - #48
Closed
daedeloth wants to merge 1 commit into
Closed
Conversation
Production still runs PHP 8.0 and phpbrake v1.0.0 requires >= 8.1. phpbrake 0.8.0 checks its options with empty(), which silently flips remoteConfig=false back to true; the notifier then phones home to airbrake.io and disables all notifications for a self-hosted Errbit. An App\Errbit\Notifier subclass re-applies the option after construction; verified against errors.catlab.eu. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013HqprN6hPwwHLXeCRbGdgo
Member
Author
|
Superseded by the PHP 8.5 upgrade PR — production moves to PHP 8.5 instead of pinning phpbrake to 0.8.0. The regression test from this branch was carried over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dokku build failed because production runs PHP 8.0 and phpbrake v1.0.0 requires >= 8.1. This pins
airbrake/phpbraketo0.8.0(the last release supporting PHP 8.0).0.8.0 has a bug the previous version didn't: its constructor checks options with
empty(), silently flippingremoteConfig => falseback totrue— so the notifier phones home to airbrake.io for configuration and disables all notifications when talking to a self-hosted Errbit. A smallApp\Errbit\Notifiersubclass re-applies the option after construction; a regression test guards it.The exact-version pin is intentional: bump to
^1.0when production moves to PHP 8.1+ (the subclass workaround stays compatible — v1.0.0 fixed theempty()check).Testing
remoteConfigstays disabled on the resolved notifier.🤖 Generated with Claude Code
https://claude.ai/code/session_013HqprN6hPwwHLXeCRbGdgo