Fix: Prevent line breaks inside for loop headers during formatting - #127
Merged
Conversation
Agent-Logs-Url: https://github.com/Catglobe/Catglobe.CgScript/sessions/b0c41998-6bed-400c-9b6e-f2960d22911c Co-authored-by: davhdavh <1201165+davhdavh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix line breaks in 'for' loop formatting
Fix: Prevent line breaks inside May 4, 2026
for loop headers during formatting
davhdavh
marked this pull request as ready for review
May 4, 2026 07:55
|
🎉 This PR is included in version 2.32.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter was splitting
forloop headers across multiple lines by treating the;separators inside the condition parentheses as statement terminators.Before:
After:
Changes
CgScriptFormatter.cs—SEMIhandler: Skip newline emission whenparenDepth > 0. Semicolons inside(...)are alwaysfor-header separators, never statement terminators.CgScriptFormatter.cs—NeedsSpaceBefore: AddprevType == SEMI → truealongside the existing comma rule, so tokens following a suppressed;still receive a space.Tests added
for (i for 0; 10) { }→ single-line header preservedfor (i = 0; i < count; i++) { }→ single-line header preservedWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.antlr.org/usr/bin/dotnet dotnet test Catglobe.CgScript.EditorSupport.Lsp.Tests/(dns block)If you need me to access, download, or install something from one of these locations, you can either: