Fix CGS020 false positive for typed array properties ("Array of X") - #151
Merged
Conversation
Closed
Copilot
AI
changed the title
[WIP] Fix wrong parse of array leading to type error
Fix CGS020 false positive for typed array properties ("Array of X")
Jul 3, 2026
davhdavh
marked this pull request as ready for review
July 3, 2026 08:08
|
🎉 This PR is included in version 2.32.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning a class property that returns a typed array (e.g.
AppProduct.Roles) to anarray-typed variable incorrectly raisedCGS020: Invalid data type 'Array of AppProductRole', expect 'array'.Root cause
"Array of <ElementType>".SemanticAnalyzer.MapToCanonicalonly recognized a fixed set of these strings ("Array of objects","Array of ints","Array of strings"); any other element type name fell through unmapped and was compared as if it were an unrelated class type.Fix
MapToCanonicalnow maps any string with the"Array of "prefix to the canonical"Array"type, instead of relying on an enumerated allow-list.Tests
"Array of AppProductRole"assigned to anarrayvariable, verifying noCGS020diagnostic is produced.