Skip to content

CATROID-1133 Fix rotation in Look#4821

Merged
dorianpercic merged 1 commit into
Catrobat:developfrom
moemgva2910:CATROID-1133
Feb 12, 2026
Merged

CATROID-1133 Fix rotation in Look#4821
dorianpercic merged 1 commit into
Catrobat:developfrom
moemgva2910:CATROID-1133

Conversation

@moemgva2910

@moemgva2910 moemgva2910 commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Fixed rotation in Look.

The Problem was that in the function rotatePointAroundPoint (in CollisionDetection.java), the rotation of a point was computed incorrectly.

The rotation of a point in this function is computed by means of the functions Math.sin() and Math.cos() respectively. This functions expect the current rotation as parameter, but this value has to be converted first to radians. The bug was caused because the rotation value was provided in degrees and not in radians.

https://jira.catrob.at/browse/CATROID-1133

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud

Copy link
Copy Markdown

@dorianpercic dorianpercic merged commit b03c6a2 into Catrobat:develop Feb 12, 2026
10 of 14 checks passed
@dorianpercic dorianpercic requested review from dorianpercic and removed request for dorianpercic February 12, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants