CATROID-1133 Fix rotation in Look#4821
Merged
Merged
Conversation
KarlDerMaisbauer
approved these changes
Jul 13, 2023
KarlDerMaisbauer
approved these changes
Oct 23, 2023
mazenger-coder
approved these changes
Nov 21, 2023
6f254e4 to
4ee5427
Compare
4ee5427 to
5923df6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixed rotation in Look.
The Problem was that in the function rotatePointAroundPoint (in CollisionDetection.java), the rotation of a point was computed incorrectly.
The rotation of a point in this function is computed by means of the functions Math.sin() and Math.cos() respectively. This functions expect the current rotation as parameter, but this value has to be converted first to radians. The bug was caused because the rotation value was provided in degrees and not in radians.
https://jira.catrob.at/browse/CATROID-1133