Skip to content

CATROID-1576 Refactor ReplaceItemInUserListAction to Kotlin#4845

Merged
ratschillerp merged 1 commit into
Catrobat:developfrom
simon-schuster:CATROID-1576
Mar 23, 2026
Merged

CATROID-1576 Refactor ReplaceItemInUserListAction to Kotlin#4845
ratschillerp merged 1 commit into
Catrobat:developfrom
simon-schuster:CATROID-1576

Conversation

@simon-schuster

@simon-schuster simon-schuster commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

https://jira.catrob.at/browse/CATROID-1576
I refactored ReplaceItemInUserListAction to Kotlin and also added a new test case which was not covered yet.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@reichli reichli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - I really like how you cleaned up the tests and added new ones!
I only have a few suggestions for minor improvements.

@simon-schuster simon-schuster force-pushed the CATROID-1576 branch 4 times, most recently from 5d5a706 to 0d35937 Compare August 29, 2023 19:25
@simon-schuster simon-schuster requested a review from reichli August 29, 2023 20:49
@sonarqubecloud

Copy link
Copy Markdown

@ratschillerp ratschillerp merged commit 0aa700b into Catrobat:develop Mar 23, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants