CATROID-1576 Refactor ReplaceItemInUserListAction to Kotlin#4845
Merged
Conversation
4276fc5 to
49dac1c
Compare
reichli
requested changes
Aug 27, 2023
reichli
left a comment
Contributor
There was a problem hiding this comment.
Thank you - I really like how you cleaned up the tests and added new ones!
I only have a few suggestions for minor improvements.
5d5a706 to
0d35937
Compare
KarlDerMaisbauer
approved these changes
Oct 23, 2023
0d35937 to
4cfafb2
Compare
4cfafb2 to
b3fb701
Compare
b3fb701 to
e0e3b46
Compare
dorianpercic
approved these changes
Mar 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://jira.catrob.at/browse/CATROID-1576
I refactored ReplaceItemInUserListAction to Kotlin and also added a new test case which was not covered yet.
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.