Skip to content

CATROID-1605: Crash when using geolocation sensors#4966

Merged
dorianpercic merged 1 commit into
Catrobat:developfrom
JayTropper:CATROID-1605
Nov 15, 2024
Merged

CATROID-1605: Crash when using geolocation sensors#4966
dorianpercic merged 1 commit into
Catrobat:developfrom
JayTropper:CATROID-1605

Conversation

@JayTropper

@JayTropper JayTropper commented Apr 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Crash when using geolocation sensors

Fixed the crashing of the geolocation sensors by using the GnnsStatus instead of the deprecated GpsStatus.
https://catrobat.atlassian.net/browse/CATROID-1605

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@JayTropper JayTropper force-pushed the CATROID-1605 branch 2 times, most recently from b804d1e to 65bf673 Compare September 13, 2024 06:58
@reichli reichli self-assigned this Sep 20, 2024
reichli
reichli requested changes Sep 20, 2024
View reviewed changes

@reichli reichli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in production code are good. But the tests need some rework.

Comment thread ...ndroidTest/java/org/catrobat/catroid/uiespresso/formulaeditor/FormulaEditorSensorListTest.kt
reichli
reichli approved these changes Nov 15, 2024
View reviewed changes

@reichli reichli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now - thank you!

@dorianpercic dorianpercic self-requested a review November 15, 2024 09:57
dorianpercic
dorianpercic approved these changes Nov 15, 2024
View reviewed changes
Comment thread catroid/src/main/java/org/catrobat/catroid/formulaeditor/GpsStatusHandler.kt Outdated
this.lastLocationGpsMillis = lastLocationGpsMillis
}

@RequiresApi(api = Build.VERSION_CODES.N)

@dorianpercic dorianpercic Nov 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed here, and also in other places, since the required min API version is 28 on develop, and PR was not rebeased. I will rebase PR and remove checks.

@dorianpercic dorianpercic merged commit 43e8609 into Catrobat:develop Nov 15, 2024
p0dlunsek pushed a commit to p0dlunsek/Catroid that referenced this pull request Jan 10, 2025
@JayTropper
CATROID-1605: Crash when using geolocation sensors (Catrobat#4966)
d64b904
dajminks pushed a commit to dajminks/Catroid that referenced this pull request Feb 3, 2025
@JayTropper
CATROID-1605: Crash when using geolocation sensors (Catrobat#4966)
e842399
dajminks pushed a commit to dajminks/Catroid that referenced this pull request Feb 3, 2025
@JayTropper
CATROID-1605: Crash when using geolocation sensors (Catrobat#4966)
781880f
Frajhamster added a commit to Frajhamster/Catroid that referenced this pull request Oct 10, 2025
@Frajhamster
CATROID-1611 Add CLT for GoToFront brick
6e96e3d 
Release 1.3.0 (Catrobat#5045)

* Migrate targetSDKVersion 34 and minSDKVersion 31 (Catrobat#5027)

* Increase Version Code and Version Number (Catrobat#5028)

* Migrate targetSDKVersion 34 and minSDKVersion 31

* Increase version code to 89 and version name to 1.3.0

* Increase Version Number to 95 (Catrobat#5029)

* Increase defaultVersionCode to 95

* Decrease minSDKVersion to 28

* Teamday fixes (Catrobat#5032)

* Fix German strings, add new german string

* Remove 'Add from local' option from the actors and objects popup menu

* Fix crash when trying to paste empty clipboard

* Fix checkstyle

* IDE-264 Migrate targetSDKVersion 34 (Catrobat#5026)

* IDE-264 Migrate targetSDKVersion 34

* IDE-264 Set ForegroundServiceType for project upload and download

* Increase defaultVersionCode to 97 (Catrobat#5037)

---------

Co-authored-by: Frajhamster <51791805+Frajhamster@users.noreply.github.com>
Co-authored-by: Thomas Reichel <thomas.reichel.1989@gmail.com>

Remove Multidex usages (Catrobat#5034)

Since the min SDK is 23, it is no longer necessary to use the Multidex library.

See the following for more info: https://developer.android.com/build/multidex#mdex-on-l

IDE-27 added androidx.core version 1.3.2 into gradle.build (Catrobat#5050)

Co-authored-by: Dominik Bek <dbek@student.tugraz.at>

CATROID-1605: Crash when using geolocation sensors (Catrobat#4966)

IDE-250 Fix all PMD warnings (Catrobat#5007)

* IDE-250 Fix all PMD warnings

* IDE-250 Move ServiceProviderTestService to separate file

* IDE-250 Fix warnings

* IDE-250 Suppress PMD warning for class TestService

IDE-110 Change "Delete Project" button to Material Design 3 Standard (Catrobat#4756)

CATROID-283 Formula Editor Calculate and Confirm Button (Catrobat#5074)

Replacing origin confirm button with a calculate and a new confirm button for better UI understanding.

add new signed releases for Paintroid and colorpicker (Catrobat#5071)

Co-authored-by: Dominik Bek <dbek@student.tugraz.at>

DEVOPS-843 add remove Pantroid directory to avoid too long file name errors (Catrobat#5081)

IDE-285: Changed the message displayed on project upload fail for clarity to users. (Catrobat#5083)

IDE-284 Change resource download server and links

IDE-284 Fix broken tests

IDE-284 Fix non-background sprite source

Added the Apple store link

Update Jenkinsfile.releaseAPK

Rectified typo from 'AKP' to 'APK'

IDE-286 delete all ocurrences of add_from_library

IDE-278 Pocketcode application crashes when you add new object which has a big width/ height difference

IDE-275 Fix timeout error when loading many projects

IDE-275 Remove personal logs

IDE-275 Fix checkstyle

IDE-266 rename 'More Details' to 'Project Properties' for clarity in overflow menu

Signed-off-by: ramoliyaYug <mastermind57369@gmail.com>

New Crowdin translations by GitHub Action

CATROID-1612 Added CLT for SetX brick

CATROID-1612 Covered required changes for CLT SetX brick

Add run configurations for all Jenkins pipeline steps (Catrobat#5095)

CATROID-1613 Fix ColorDetection ignoring z-index (Catrobat#5041)

add laser cut bricks

add engrave and cut path to generated svg

* remane extension

fix unit test

add xml resources for plotter bricks

add plot and laser arc bricks

add turtle for plotting

change header to 2010-2025

implement review comments

add brick urls test
fix null ptr checks

fix laser arc text

adapt tests

fix static analysis errors

fix share plot action

remove redundant non null assertions

New Crowdin translations by GitHub Action

DEVOPS-851 Add MidiDroid dependency as aar-file

Since the dependency is not available anymore on jcenter it's aar-file
is added into the repo as a workaround. Newer version of this dependency
only work with Java 20 onwards, which is not yet available on the develop
branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reichli reichli reichli approved these changes
@dorianpercic dorianpercic dorianpercic approved these changes

Assignees

@reichli reichli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JayTropper @reichli @dorianpercic