Skip to content

IDE-278 Pocketcode application crashes when you add new object which …#5077

Merged
reichli merged 1 commit into
Catrobat:developfrom
ShingHanHuang:IDE-278
May 2, 2025
Merged

IDE-278 Pocketcode application crashes when you add new object which …#5077
reichli merged 1 commit into
Catrobat:developfrom
ShingHanHuang:IDE-278

Conversation

@ShingHanHuang

Copy link
Copy Markdown

…has a big width/ height difference

When you add a new object in your Pocketcode project that has a very large height/width difference (over 1:150), the scaling algorithm calculates a width or height of 0, which causes the application to crash.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud

Copy link
Copy Markdown

@reichli reichli self-assigned this May 2, 2025

@reichli reichli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you very much for the fix!

@reichli reichli merged commit 130eb30 into Catrobat:develop May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants