Skip to content

IDE-284 Change resource download server and links#5078

Merged
reichli merged 1 commit into
Catrobat:developfrom
Frajhamster:IDE-284
Apr 27, 2025
Merged

IDE-284 Change resource download server and links#5078
reichli merged 1 commit into
Catrobat:developfrom
Frajhamster:IDE-284

Conversation

@Frajhamster

@Frajhamster Frajhamster commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Jira ticket: https://catrobat.atlassian.net/browse/IDE-284

Description:

  • Changed assets/resources download server links
  • Removed old unused related code
  • A few lines of old code still remains, but should be deleted when the share server completely closes
  • Adapted tests

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@urkat urkat left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

IDE-284 Fix broken tests

IDE-284 Fix non-background sprite source
@sonarqubecloud

Copy link
Copy Markdown

@reichli reichli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@reichli reichli merged commit cd61f93 into Catrobat:develop Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants