Skip to content

IDE-287 Fix build errors in build variants#5102

Merged
reichli merged 2 commits into
Catrobat:developfrom
doppem15:IDE-287
Dec 15, 2025
Merged

IDE-287 Fix build errors in build variants#5102
reichli merged 2 commits into
Catrobat:developfrom
doppem15:IDE-287

Conversation

@doppem15

@doppem15 doppem15 commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

Fixed build errors in all build variants by updating constants in FlavoredConstants.java to match recent changes in the Media Library.
https://catrobat.atlassian.net/browse/IDE-287

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@reichli reichli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build variant now works again - thank you!
Please also check the other remaining build variants: createAtSchool, lunaAndCat, mindstorms, phiro and pocketCodeBeta.

@sonarqubecloud

Copy link
Copy Markdown

@khaledelnaggar khaledelnaggar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dorianpercic dorianpercic self-requested a review December 5, 2025 12:44

@dorianpercic dorianpercic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All flavors working; tested locally.

@sonarqubecloud

sonarqubecloud Bot commented Dec 5, 2025

Copy link
Copy Markdown

@reichli reichli self-requested a review December 15, 2025 11:44

@reichli reichli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All flavors changed now - thank you!

@reichli reichli merged commit 7416910 into Catrobat:develop Dec 15, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants