Skip to content

IDE-291 Test FormulaEditorKeyboardTest.testConfirmButtonString fails locally and on Jenkins#5106

Merged
ratschillerp merged 1 commit into
Catrobat:developfrom
doppem15:IDE-291
Feb 26, 2026
Merged

IDE-291 Test FormulaEditorKeyboardTest.testConfirmButtonString fails locally and on Jenkins#5106
ratschillerp merged 1 commit into
Catrobat:developfrom
doppem15:IDE-291

Conversation

@doppem15

Copy link
Copy Markdown
Contributor

The testConfirmButtonString test is outdated and may have been overlooked during an update. Since the button under test is now an image, its text string can no longer be tested directly. Instead, the content description is now being verified, and the test has been renamed to testConfirmButtonContentDescription.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • [] After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud

Copy link
Copy Markdown

@reichli reichli added the Active Member Tickets that are assigned to members that are still currently active label Dec 25, 2025
@dorianpercic dorianpercic self-requested a review December 29, 2025 14:42
@dorianpercic

Copy link
Copy Markdown
Contributor

Rebased PR.

@doppem15 If possible, please add the JIRA ticket to the PR description and as soon as you have a finished PR move your ticket to In Code Review with Assignee: Unassigned :)

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

sonarqubecloud Bot commented Feb 5, 2026

Copy link
Copy Markdown

@ratschillerp ratschillerp merged commit c9e6082 into Catrobat:develop Feb 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants