Skip to content

CATROID-1632 Fix SceneControllerTest#5142

Merged
dorianpercic merged 1 commit intoCatrobat:developfrom
Kale2605:CATROID-1632
Jan 29, 2026
Merged

CATROID-1632 Fix SceneControllerTest#5142
dorianpercic merged 1 commit intoCatrobat:developfrom
Kale2605:CATROID-1632

Conversation

@Kale2605
Copy link
Copy Markdown
Contributor

@Kale2605 Kale2605 commented Jan 22, 2026

Fix name access
Add Nullable decorator to fix Java->Kotlin issues (wth this took ages to find out)

https://catrobat.atlassian.net/browse/CATROID-1632?atlOrigin=eyJpIjoiMzE2NDQ2YjliNzIyNGYxZWI0MjA4ODdjNzExYTA0NDQiLCJwIjoiaiJ9

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Fix name access
Add Nullable decorator to fix Java->Kotlin issues (wth this took ages to find out)
@Kale2605 Kale2605 marked this pull request as ready for review January 22, 2026 07:47
@sonarqubecloud
Copy link
Copy Markdown

@dorianpercic dorianpercic self-requested a review January 24, 2026 16:46
Copy link
Copy Markdown
Contributor

@Frajhamster Frajhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ratschillerp ratschillerp added the Active Member Tickets that are assigned to members that are still currently active label Jan 29, 2026
@dorianpercic dorianpercic merged commit d65ab2e into Catrobat:develop Jan 29, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants