CATROID-1652 Add missing Xstream aliases and fix tests#5201
Merged
Conversation
This commits fixes the subtype-lookup in `ClassDiscoverer` thereby fixing the two test classes `BricksXmlSerializerTest` and `ScriptsXmlSerializerTest`. These tests then uncovered bricks which are not considered during aliasing in the `XStreamSerializer`. This commit also adds those bricks to ensure proper serialization. Apparently it also fixes the tests `UpdateVariableInFormulaBrickTest`, `UpdateVariableInFormulaScriptBrickTest` and `ScriptsBrickDragNDropListTest`. Altogether this fixes roughly 1.000 unit tests which did not run previous to this fix. Also the catrobat language version was increased to 1.14 to account for the newly added bricks.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes XML serialization test coverage by improving subtype discovery in test utilities, adding missing XStream aliases for newly introduced bricks, and bumping the Catrobat language version.
Changes:
- Update
ClassDiscovererReflections configuration to improve subtype lookup. - Add XStream aliases for Plot and Laser Cutter bricks to ensure proper serialization.
- Increase
CURRENT_CATROBAT_LANGUAGE_VERSIONto1.14.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
catroid/src/test/java/org/catrobat/catroid/test/xmlformat/ClassDiscoverer.java |
Adjusts Reflections scanning configuration used by serializer tests to discover subclasses. |
catroid/src/main/java/org/catrobat/catroid/io/XstreamSerializer.java |
Adds missing aliases for Plot/Laser-related bricks so XML output uses <brick type="..."> consistently. |
catroid/src/main/java/org/catrobat/catroid/common/Constants.java |
Bumps language version to reflect newly supported bricks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harshsomankar123-tech
approved these changes
Apr 20, 2026
harshsomankar123-tech
left a comment
Member
There was a problem hiding this comment.
@reichli Thanks! LGTM.
ratschillerp
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://catrobat.atlassian.net/browse/CATROID-1652
This commits fixes the subtype-lookup in
ClassDiscovererthereby fixing the two test classesBricksXmlSerializerTestandScriptsXmlSerializerTest. These tests then uncovered bricks which are not considered during aliasing in theXStreamSerializer. This commit also adds those bricks to ensure proper serialization.Apparently it also fixes the tests
UpdateVariableInFormulaBrickTest,UpdateVariableInFormulaScriptBrickTestandScriptsBrickDragNDropListTest. Altogether this fixes roughly 1.000 unit tests which did not run previous to this fix.Also the catrobat language version was increased to 1.14 to account for the newly added bricks.
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.