v4.8.1 — the send button is readable when the workspace is dark - #2
Merged
Conversation
The composer's send button sets its background to --ink and its label to a fixed white. --ink is the text colour, so under a dark theme it is near-white (#f1f2f4) and the label disappeared into the button: white on white, 1.12:1. The button rendered as a blank box with no word on it, and the only way to know it was Send was to have used it in light mode first. The label now follows --surface, which is the pairing the rest of the interface already uses for anything sitting on --ink — the shell's dark banner and its update line both do. That gives 15.70:1 in dark, and light mode is untouched because --surface is #ffffff there, exactly what was hardcoded. Every other fixed white label in the pages sits on --brand, --mk, --note or --keep, which stay mid-tone in both themes. --ink was the only token that inverts, so this was the only place the fault could occur. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed to white while its background follows
--ink, which is the text colourand therefore near-white under a dark theme. The button rendered as a blank
white box, at a contrast of 1.12:1. The label now follows
--surface, thepairing the rest of the interface already uses, giving 15.70:1 in dark and
leaving light mode exactly as it was.
Contrast on the button label, measured from the token values in
tokens.css:#fff)var(--surface))Not verified visually — the Chrome extension was disconnected. The numbers come from the real token values, not from a render.
Release PR for 4.8.1.
🤖 Generated with Claude Code