fix: Gamebreaking bug within NetworkBuff - #29
Merged
Conversation
Fixes read_number not behaving correctly by adding the missing this->read_position modification
tobezdev
approved these changes
Nov 12, 2025
tobezdev
left a comment
tobezdev
left a comment
Contributor
There was a problem hiding this comment.
Such a holy one liner, don't think it needed a full review though LOL
Member
Author
I know, its muscle memory lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug related to the Network buffer, was found with the
NetworkBuff.AllocatedAndStaticParitytest (issue #28)Changes:
this->readPositionwithinNetworkBuff::read_numberThis test result will be closely monitored before eventually being marked as resolved