Fix for NamesAndTypes incorrectly relabeling 3D objects from an image#95
Merged
Fix for NamesAndTypes incorrectly relabeling 3D objects from an image#95
Conversation
Member
|
@callum-jpg Sorry I missed this! I don't think it's originally my code but came over from the main repo during the core split. I expect that the intention was to handle missing label values. I'm sure that there will now be far more efficient ways to achieve the same thing as the utility function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentative fix for CellProfiler/CellProfiler#4505
When loading objects from a 3d image, NamesAndTypes relied on a method (specifically, get_image_volume in core _objects_image.py) that labelled planes individually using
convert_image_to_objectsand stacked the result. As some cells can be present in one plane but not others, this led to differences in labelling for the same cell between planes. By removing the label recalculations, the original segmentation is preserved.@DavidStirling , is there some particular scenario this original fix was trying to solve? We note that planes are converted from int64 to int32 here, which we have preserved, so wondered if theres some particular case we are overlooking here. Could it also be that
convert_image_to_objectswas called to help deal with missing objects, similar to CellProfiler/CellProfiler#4485?