Skip to content

Attempt to add Travis CI support#34

Merged
LeeKamentsky merged 9 commits intoCellProfiler:masterfrom
jakirkham:add_travis
Sep 29, 2015
Merged

Attempt to add Travis CI support#34
LeeKamentsky merged 9 commits intoCellProfiler:masterfrom
jakirkham:add_travis

Conversation

@jakirkham
Copy link
Copy Markdown
Contributor

How this works.

  • Try to handle Python and related dependencies with conda. Makes it really easy to install numpy and the sort. Also, uses binaries so it is really fast (no build time). Usually, has recent versions.
  • Uses a Java language environment. It is needed for some things in here anyways. Also, the Travis Python environment would be replaced with conda's so we don't care about it.
  • Use pip to install the latest python-javabridge. Easy to do. Likely what someone will do when installing themselves.
  • Builds the sphinx docs with the html target. Just verifies the docs can still be built. May provide elucidating warnings in-case somebody isn't following correct syntax.
  • Provides some coverage setting. Could be used to report to coveralls.io given some tweaks to python-javabridge.

@LeeKamentsky
Copy link
Copy Markdown

👍 looking forward to it, thx.

@jakirkham
Copy link
Copy Markdown
Contributor Author

If you setup coveralls now, I can enable support for it in this PR. I can some default settings for it, but you may wish to fine tune it further.

@jakirkham jakirkham force-pushed the add_travis branch 7 times, most recently from b8208e4 to 900248d Compare September 28, 2015 19:46
@jakirkham jakirkham changed the title WIP: Attempt to add Travis CI support Attempt to add Travis CI support Sep 28, 2015
@jakirkham
Copy link
Copy Markdown
Contributor Author

Alright, this works. I'm rolling back the coverage support during testing as it will require a change to python-javabridge to support it. I left the original commits in there so if you want to take a look at how it would of worked you can.

@LeeKamentsky
Copy link
Copy Markdown

Nice. @0x00b1 what do you think? It runs the unit tests - I like. IMHO - getting the travis build status is the big win we wanted. Code coverage would be nice, but we wouldn't act on the results for a while at least.

@jakirkham
Copy link
Copy Markdown
Contributor Author

There could be a way to workaround this using coverage run ( http://coverage.readthedocs.org/en/latest/#quick-start ). Though nose already supports coverage with a simple option. Its just a matter of getting python-javabridge to allow for that option. So, it shouldn't be hard, but I didn't want to hang this up over getting those set up and in sync.

@jakirkham
Copy link
Copy Markdown
Contributor Author

Also, it might be worth build the docs, but I'm not quite sure how you do that for your project. I tried running make html inside the docs directory, but got several tracebacks regarding a failure to import javabridge, which was installed in the environment. So, it may take some more playing around.

Scratch that. It was picking up the wrong sphinx.

@jakirkham
Copy link
Copy Markdown
Contributor Author

Added a doc building step, as well.

@jakirkham
Copy link
Copy Markdown
Contributor Author

Tried to better lay out my rational for my design choices above.

LeeKamentsky pushed a commit that referenced this pull request Sep 29, 2015
Attempt to add Travis CI support
@LeeKamentsky LeeKamentsky merged commit 801c789 into CellProfiler:master Sep 29, 2015
@jakirkham jakirkham deleted the add_travis branch September 29, 2015 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants