Skip to content

Conversation

@Dhruv-Mehndhiratta-Centml
Copy link
Contributor

  • added hardware instance mapping api, removed hard coded value of it from the cli
  • added cached pattern for using the api response so that it doesn't end up calling api again and again

@Dhruv-Mehndhiratta-Centml Dhruv-Mehndhiratta-Centml linked an issue Jun 19, 2024 that may be closed by this pull request
@Dhruv-Mehndhiratta-Centml
Copy link
Contributor Author

Dhruv-Mehndhiratta-Centml commented Jun 19, 2024

Hey @anandj91 i have noticed in case of get_hardware_instances_hardware_instances_get in external_api generator we are not setting up auth_settings as https bearer , its resulting into giving rbac access denied error for this particular api because its not having access token inside its request, however if i manually add or update this to below mentioned change, this api request start passing and resulting into 200 success response, this is also applicable for the prebuild images api too.

 # authentication setting
    _auth_settings: List[str] = [
        'HTTPBearer'
    ]

let me check how can i add this to generated client permanently so that it can act as a permanent fix for this api

Screenshot 2024-06-19 at 2 49 53 PM

@Dhruv-Mehndhiratta-Centml Dhruv-Mehndhiratta-Centml changed the title worked on adding hardware instance mapping api to cli added hardware instance mapping api to cli Jun 19, 2024
@Dhruv-Mehndhiratta-Centml Dhruv-Mehndhiratta-Centml added the enhancement New feature or request label Jun 19, 2024
@anandj91 anandj91 added this to the june-end milestone milestone Jun 20, 2024
@Dhruv-Mehndhiratta-Centml Dhruv-Mehndhiratta-Centml force-pushed the 50-fetch-hardware-instances-for-cli branch from 9ae4de6 to dbbfcba Compare June 27, 2024 16:20
@Dhruv-Mehndhiratta-Centml Dhruv-Mehndhiratta-Centml force-pushed the 50-fetch-hardware-instances-for-cli branch from 9d2bde8 to d112fd9 Compare June 27, 2024 20:41
@Dhruv-Mehndhiratta-Centml Dhruv-Mehndhiratta-Centml deleted the 50-fetch-hardware-instances-for-cli branch June 27, 2024 21:10
Dhruv-Mehndhiratta-Centml added a commit that referenced this pull request Jul 5, 2024
* worked on adding hardware instance mapping api to cli (#52)

* fixing api call initialize issue by removing decorators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetch Hardware instances for CLI

2 participants