-
Notifications
You must be signed in to change notification settings - Fork 1
Bugfix: making the hardware instance api call to defer #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Dhruv-Mehndhiratta-Centml
merged 2 commits into
main
from
bugfix/fix-common-decorator-function-api-defer-call
Jul 5, 2024
Merged
Bugfix: making the hardware instance api call to defer #61
Dhruv-Mehndhiratta-Centml
merged 2 commits into
main
from
bugfix/fix-common-decorator-function-api-defer-call
Jul 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dhruv-Mehndhiratta-Centml
commented
Jul 2, 2024
- currently we have attached the hardware instance mapping api call to decorator function to fetch common click utils which are common in inference and compute deployment but because its a decorator function its trying to make the api call when we are executing the centml command, its working perfectly fine for the user who is already loggedin but for the user who is logged out and when the same user try to see the centml options its making hardware instance api call and eventually leading it to fail the api call
- in order to fix the same now we are going the load the choices of hardware instance mapping in a deferred way and if incase user enters any incorrect pricing tier it will result to the user to provide the same listing options so that user can only enter allowed values
7a1c995 to
49f9c80
Compare
destefy
reviewed
Jul 2, 2024
anandj91
reviewed
Jul 3, 2024
anandj91
requested changes
Jul 3, 2024
anandj91
requested changes
Jul 4, 2024
anandj91
approved these changes
Jul 5, 2024
410c262 to
6f79c04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.