Make ExclusiveSynchronizationContext less generic#12
Merged
Conversation
Motivation ---------- This may reduce JIT/AOT code size in some scenarios by moving some methods not impacted by the type of the awaiter out of the generic context.
There was a problem hiding this comment.
Pull Request Overview
This refactoring removes the generic type parameter from ExclusiveSynchronizationContext to reduce JIT/AOT code generation overhead. The change moves the generic constraint from the class level to the Run method, allowing the synchronization context to be shared across different awaiter types while maintaining type safety.
- Converted
ExclusiveSynchronizationContext<TAwaiter>to a non-generic class - Made the
Runmethod generic instead of the entire class - Updated all instantiation sites to use the simplified constructor
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/CenterEdge.Async/ExclusiveSynchronizationContext.cs | Removed generic type parameter from class and moved it to the Run method |
| src/CenterEdge.Async/AsyncHelper.cs | Updated constructor calls to remove generic type arguments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RobRobertsCE
approved these changes
Sep 29, 2025
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This may reduce JIT/AOT code size in some scenarios by moving some methods not impacted by the type of the awaiter out of the generic context.