Skip to content

Make ExclusiveSynchronizationContext less generic #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
centeredgebot merged 1 commit into from
Sep 29, 2025
Merged

Make ExclusiveSynchronizationContext less generic #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/CenterEdge.Async/AsyncHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public static void RunSync(Func<Task> task)
public static void RunSync<TState>(Func<TState, Task> task, TState state)
{
var oldContext = SynchronizationContext.Current;
using var synch = new ExclusiveSynchronizationContext<TaskAwaiter>(oldContext);
using var synch = new ExclusiveSynchronizationContext(oldContext);
SynchronizationContext.SetSynchronizationContext(synch);
try
{
Expand Down Expand Up @@ -100,7 +100,7 @@ public static void RunSync(Func<ValueTask> task)
public static void RunSync<TState>(Func<TState, ValueTask> task, TState state)
{
var oldContext = SynchronizationContext.Current;
using var synch = new ExclusiveSynchronizationContext<ValueTaskAwaiter>(oldContext);
using var synch = new ExclusiveSynchronizationContext(oldContext);
SynchronizationContext.SetSynchronizationContext(synch);
try
{
Expand Down Expand Up @@ -153,7 +153,7 @@ public static T RunSync<T>(Func<Task<T>> task)
public static T RunSync<T, TState>(Func<TState, Task<T>> task, TState state)
{
var oldContext = SynchronizationContext.Current;
using var synch = new ExclusiveSynchronizationContext<TaskAwaiter<T>>(oldContext);
using var synch = new ExclusiveSynchronizationContext(oldContext);
SynchronizationContext.SetSynchronizationContext(synch);
try
{
Expand Down Expand Up @@ -206,7 +206,7 @@ public static T RunSync<T>(Func<ValueTask<T>> task)
public static T RunSync<T, TState>(Func<TState, ValueTask<T>> task, TState state)
{
var oldContext = SynchronizationContext.Current;
using var synch = new ExclusiveSynchronizationContext<ValueTaskAwaiter<T>>(oldContext);
using var synch = new ExclusiveSynchronizationContext(oldContext);
SynchronizationContext.SetSynchronizationContext(synch);
try
{
Expand Down
6 changes: 3 additions & 3 deletions src/CenterEdge.Async/ExclusiveSynchronizationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@
namespace CenterEdge.Async;

// Note: Sealing this class can help JIT make non-virtual method calls and inlined method calls for virtual methods
internal sealed class ExclusiveSynchronizationContext<TAwaiter>(
internal sealed class ExclusiveSynchronizationContext(
SynchronizationContext? parentSynchronizationContext)
: SynchronizationContext, IDisposable
where TAwaiter : struct, ICriticalNotifyCompletion
{
private readonly BlockingCollection<WorkItem> _items = [];

Expand Down Expand Up @@ -56,7 +55,8 @@ private void EndMessageLoop()
_items.CompleteAdding();
}

public void Run(TAwaiter awaiter)
public void Run<TAwaiter>(TAwaiter awaiter)
where TAwaiter : struct, ICriticalNotifyCompletion
{
// Register a callback to run when the original awaiter is completed
// We use UnsafeOnCompleted so it doesn't flow ExecutionContext
Expand Down