[ENG-11381] Workflow Launcher - #1039
Merged
brianjgeiger merged 18 commits intoAug 10, 2026
Merged
Conversation
brianjgeiger
approved these changes
Aug 10, 2026
brianjgeiger
left a comment
brianjgeiger
left a comment
Contributor
There was a problem hiding this comment.
One thing I think we'll need to fix in the future.
| expect(storageService.setCachedUser).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('getCurrentUser should keep cached user when api returns no user but cache exists', async () => { |
Contributor
There was a problem hiding this comment.
I don't think this is correct behavior. If the API returns no user, then the user isn't logged in and won't be able to access the API as if they were. We'll likely have to make a ticket to fix this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.