[ENG-9758] Change settings page to default to correct notifications #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
commented
Nov 13, 2025
|
|
||
| if (event === SubscriptionEvent.GlobalReviews) { | ||
| const subs = this.notificationSubscriptions(); | ||
| const match = subs.find((s) => (s.event as string) === 'new_pending_submissions'); |
Author
There was a problem hiding this comment.
provider id should new_pending_submissions always is for provider submissions, id pattern for that is <provider_name>_new_pending_submissions so it must be the same as the sub.id
Collaborator
|
@Johnetordoff I see that this is old code. It will cause conflicts because unit tests have already been added for |
nsemets
reviewed
Nov 13, 2025
src/app/features/settings/notifications/notifications.component.ts
Outdated
Show resolved
Hide resolved
nsemets
reviewed
Nov 13, 2025
…and update SubscriptionEvent
Johnetordoff
force-pushed
the
fix/notification-prefs
branch
from
c86c264 to
171177b
Compare
…ular-osf into fix/notification-prefs # Conflicts: # src/app/features/settings/notifications/notifications.component.spec.ts # src/app/shared/enums/subscriptions/subscription-event.enum.ts
…enterForOpenScience/angular-osf into fix/notification-prefs
nsemets
reviewed
Nov 14, 2025
src/app/features/settings/notifications/notifications.component.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
@Johnetordoff Looks good, just fix one comment. |
…t.ts Co-authored-by: nsemets <nsemets@exoft.net>
brianjgeiger
approved these changes
Nov 14, 2025
brianjgeiger
merged commit 9aa505d
into
CenterForOpenScience:feature/notifications-refactor
3 checks passed
cslzchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…freq defaults
Purpose
Make the notification preferences default and change to correct values. Corrosponses with this PR:
CenterForOpenScience/osf.io#11441
Summary of Changes
Simple logic changes to make dropdowns functional
Screenshot(s)
Side Effects
CenterForOpenScience/osf.io#11441
QA Notes