Skip to content

[ENG-2792] Fix special chars in node license copyright holder #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2022
Merged

[ENG-2792] Fix special chars in node license copyright holder #1641

merged 2 commits into from
Sep 9, 2022

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Aug 29, 2022 •
edited by atlassian bot
Loading

Purpose

  • Fix special characters (&, > and <) in node-license copyright holder field

Summary of Changes

  • Wrap copyright holder in fixSpecialChars in the node-license transform

Screenshot(s)

  • After loading a draft registration that had a special character in the copyright holder field:
    image

Side Effects

  • None

QA Notes

  • The copyright holder in the API will still have special characters encoded as &amp;, &gt;, and &lt;.

@coveralls
Copy link

coveralls commented Aug 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3016271093

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 71.302%
Totals Coverage Status
Change from base Build 2972931429: -0.009%
Covered Lines: 5385
Relevant Lines: 7338
💛 - Coveralls

brianjgeiger
brianjgeiger approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@futa-ikeda futa-ikeda added this to the 22.9.0 milestone Aug 31, 2022
adlius
adlius reviewed Sep 1, 2022
View reviewed changes
Copy link
Contributor

@adlius adlius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am understanding this correctly, this only affects how that field is shown on the FE, but won't do anything to change the content of the PATCH request when we update the field, correct?

@futa-ikeda
Copy link
Contributor Author

futa-ikeda commented Sep 1, 2022

If I am understanding this correctly, this only affects how that field is shown on the FE, but won't do anything to change the content of the PATCH request when we update the field, correct?

Yea, the PATCH request payload will have &, but the response from the api will still be &amp;

@brianjgeiger brianjgeiger merged commit 69785a8 into CenterForOpenScience:develop Sep 9, 2022
chth0n1x pushed a commit to chth0n1x/ember-osf-web that referenced this pull request Feb 1, 2023
@futa-ikeda
Fix special chars in node license copyright holder (CenterForOpenScie…
9addd43 
…nce#1641)

-   Ticket: [ENG-2792]

## Purpose
- Fix special characters (`&`, `>` and `<`) in node-license copyright holder field

## Summary of Changes
- Wrap copyright holder in `fixSpecialChars` in the `node-license` transform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adlius adlius adlius approved these changes

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

22.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@futa-ikeda @coveralls @adlius @brianjgeiger