Skip to content

[ENG-2792] Fix special chars in node license copyright holder #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2022
Merged

[ENG-2792] Fix special chars in node license copyright holder #1641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b4b41b
Fix special chars in node license copyright holder
futa-ikeda Aug 29, 2022
c5894d1
Merge branch 'develop' into node-license-special-chars
futa-ikeda Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/transforms/node-license.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Transform from '@ember-data/serializer/transform';

import { NodeLicense } from 'ember-osf-web/models/node';
import fixSpecialChars from 'ember-osf-web/utils/fix-special-char';
import { camelizeKeys, snakifyKeys } from 'ember-osf-web/utils/map-keys';

interface SerializedNodeLicense {
Expand All @@ -25,7 +26,8 @@ export default class NodeLicenseTransform extends Transform {
} = camelizeKeys(value) as DeserializedNodeLicense;

return Object.freeze({
copyrightHolders: typeof copyrightHolders === 'string' ? copyrightHolders : copyrightHolders.join(', '),
copyrightHolders: typeof copyrightHolders === 'string' ? fixSpecialChars(copyrightHolders)
: fixSpecialChars(copyrightHolders.join(', ')),
year,
});
}
Expand Down