Make dialog box scroll on overflow #1649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3039146144
💛 - Coveralls |
futa-ikeda
approved these changes
Sep 2, 2022
| margin-top: 20px; | ||
| } | ||
|
|
||
| :global(.modal-body) { |
Contributor
There was a problem hiding this comment.
Instinctively, the application of this global class makes me nervous, but it's just limited to the analytics engine it seems and it makes sure any additional BsModal doesn't suffer from the no-scroll behavior... I'm torn, but I think it's good.
adlius
approved these changes
Sep 12, 2022
chth0n1x
pushed a commit
to chth0n1x/ember-osf-web
that referenced
this pull request
Feb 1, 2023
## Purpose The modal for the links on the project analytics page doesn't scroll. Instead, it just runs off the screen if there's too much content, and that content will never be seen. This makes it so that the dialog box behaves properly with the scrolling and the not overfilling the screen. ## Summary of Changes 1. Add max-height to the modal 2. Set overflow to scroll ## Side Effects If there were any other `bs-modal-simple`s on the page, they would also be upgraded. But there aren't, so this is isolated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The modal for the links on the project analytics page doesn't scroll. Instead, it just runs off the screen if there's too much content, and that content will never be seen. This makes it so that the dialog box behaves properly with the scrolling and the not overfilling the screen.
Summary of Changes
Screenshot(s)
Side Effects
If there were any other
bs-modal-simples on the page, they would also be upgraded. But there aren't, so this is isolated.