This repository was archived by the owner on Apr 14, 2026. It is now read-only.
Basket/tellurium#1856
Merged
brianjgeiger merged 20 commits intodevelopfrom May 1, 2023
Merged
Conversation
## Purpose Remove the silencing of the copy-copyable deprecation. As near as I can tell, we aren't hitting this deprecation at all. I ran through a bunch of pages in manual testing and I ran the tests, and neither hit the deprecation warning, so we should be okay with this one. ## Summary of Changes 1. Un-silenced the deprecation 2. Updated caniuse-lite's browser db
## Purpose Un-silence the deprecation for ember-inflector.globals and see if anything breaks. Apparently, nothing does break. ## Summary of Changes 1. Remove the deprecation silencer.
## Purpose To remove dependency on Bootstrap ## Summary of Changes Removed all the bootstrap from the dashboard-item component
## Purpose Unsilence the legacy test helpers using the [new test api for engines](ember-engines/ember-engines#653). ## Summary of Changes 1. Use new test api 2. Fix misc problems ## Side Effects The test server seems to not want to rebuild after making changes to tests. Hopefully this isn't a larger problem with the rebuild process, or if it is, that it goes away after further upgrades. Also one test broke in a way that I can't find a reason for, so I'm hoping that an update to ember-qunit and ember-qunit-sinon will fix. A ticket has been made to do that, but it'll have to wait until after we've gotten rid of ember-bootstrap.
## Purpose Ember engines 0.9.0 broke rebuilds, and isn't necessary for deprecation fixes since the testing api was in 0.8.3. ## Summary of Changes 1. Downgrade ember-engines to 0.8.3
## Purpose Remove bootstrap ## Summary of Changes Removed bootstrap css formatting from the draft-registration-card
## Purpose I've started running tests with the deprecation warning set to a breakpoint, and it picked up a few deprecations that were missed in previous attempts to remove them. This corrects those cases. ## Summary of Changes 1. Explicitly inject store in register controller 2. Remove file-editor and ember-ace, as ember-ace has a deprecation and we don't use the file-editor any more 3. Don't use `toJson()` in tests, which has been deprecated and was probably just a bad way to do those tests
## Purpose Un-silence the deprecation for [link-to-positional-arguments](https://deprecations.emberjs.com/v3.x/#toc_ember-glimmer-link-to-positional-arguments) and fix any problems that arise because of it. ## Summary of Changes 1. Un-silence deprecation 2. Fix links that use positional arguments 3. Stop using BsNav's link-to in favor of our own links 4. Skip a test 5. Fix other tests
# Conflicts: # lib/analytics-page/addon/application/template.hbs # package.json
## Purpose Turn jQuery integration off. This causes some subtle timing issues with rendering which are fixable with timeouts. ## Summary of Changes 1. Disable jQuery integration 2. Sprinkle timeouts throughout the tests where necessary to get them to pass again.
Make fetch requests authenticated
## Purpose Un-silence the deprecation for mutation after consumption and fix the problems that arise. Basically, things can't happen on init or in construction if they might write to a variable being read on render, so this puts those times it happened into a bit later of a part of the process. ## Summary of Changes 1. Un-silence the deprecation 2. Fix File Browser breadcrumbs and upload widget 3. Fix make-decision-dropdown 4. Fix moderators list row
## Purpose Un-silence the deprecation for computed property overrides and fix the problems. ## Summary of Changes 1. Un-silence the deprecation 2. Update validated input to accept isActive as a parameter and computer the active state property properly rather than overriding the computed property 3. Fix the logged-out home page carousel 4. Update the current-user stub to accept a testUser rather than overriding the user computed property 5. Fix usage of current-user in tests to use the new testUser property
## Purpose Refactored all the bootstrap css out of the templates ## Summary of Changes Refactored all the bootstrap css out of the templates
…ks page (#1851) * Add data-test selectors to registration components and links page * Fix tests
Pull Request Test Coverage Report for Build 4831754746
💛 - Coveralls |
futa-ikeda
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Merge the tickets for the Tellurium release. Note: Please do a regular merge with this, rather than a Squash and Merge.