Skip to content

[Institution Rework] [ENG-4205] Customize Exception Handling - #76

Merged
cslzchen merged 5 commits into
CenterForOpenScience:feature/institution-reworkfrom
cslzchen:feature/customized-errors
Jan 20, 2023
Merged

[Institution Rework] [ENG-4205] Customize Exception Handling#76
cslzchen merged 5 commits into
CenterForOpenScience:feature/institution-reworkfrom
cslzchen:feature/customized-errors

Conversation

@cslzchen

@cslzchen cslzchen commented Jan 20, 2023

Copy link
Copy Markdown
Contributor

Ticket

https://openscience.atlassian.net/browse/ENG-4205

Purpose

Customize Exception Handling

  • Selective Login Denied

isntn-sso-selective-login-denied

  • Unexpected API Error

instn-sso-api-error

  • Duplicate SSO Identity

instn-sso-duplicate-identity

  • Attribute Parsing / Normalization Failed

instn-sso-attribute-parsing-failed

  • Attribute missing

instn-sso-missing-attributes

  • Inactive Account

instn-sso-inactive-account

  • Other / Generic Error

instn-sso-error-generic-failure

Requires: CenterForOpenScience/osf.io#10299

Changes

  • Created four new customized exceptions
  • Refactor exception flow wit both new and existing exceptions
  • Update FE pages/languages

QA Notes

Local Dev QA

* Attribute exceptions: missing or invalid attributes, parsing or
  normalizationfailures, etc.
* API exceptions: payload encryption/encoding, network/communication,
  expected and unexpected response, etc.
* Special exceptions: selective SSO denied, invalid account status,
  duplicate identity, etc.
* Generic exception: the rest
@cslzchen
cslzchen merged commit 739b125 into CenterForOpenScience:feature/institution-rework Jan 20, 2023
@cslzchen
cslzchen deleted the feature/customized-errors branch October 7, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant