[ENG-8556] Update CAS pages to match Angular update: header, footer and left pane #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
changed the title
cslzchen
reviewed
Sep 12, 2025
Contributor
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
I pulled down and tested with my local OSF.
Looks good and standard workflows work as before with the side bar / header / footer change in place.
Exception pages failed but it is as expected which we can fix later in their tickets.
I am going to tweak/add the code to init the links in OsfUrlProperties. Afterwards, I will push back to the PR for a final look before merge.
cslzchen
reviewed
Sep 12, 2025
cslzchen
reviewed
Sep 12, 2025
cslzchen
reviewed
Sep 12, 2025
cslzchen
reviewed
Sep 12, 2025
cslzchen
reviewed
Sep 12, 2025
cslzchen
approved these changes
Sep 12, 2025
Contributor
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Changes looks good verified locally, I am going to make two quick change before merge.
- Remove
collectionsinOsfUrlProperties - Refactor
leftpaneintoleftpaneosf
src/main/java/io/cos/cas/osf/configuration/model/OsfUrlProperties.java
Outdated
Show resolved
Hide resolved
cslzchen
changed the title
cslzchen
merged commit de6ea17
into
CenterForOpenScience:feature/angular-like-pages
1 check passed
cslzchen
reviewed
Sep 13, 2025
| } | ||
|
|
||
| .main-background-gradient { | ||
| background: linear-gradient(90deg, rgba(255, 255, 255, 0.75), rgba(255, 255, 255, 0.80)), url(/images/dark-blue-gradient.png) center center no-repeat; |
Contributor
There was a problem hiding this comment.
Follow-up: I ran into an issue that this /images/dark-blue-gradient.png is not found. Not sure if this has anything to do of button having a white background.
cslzchen
added a commit
that referenced
this pull request
Sep 30, 2025
…nd left pane (#88) --------- Co-authored-by: Longze Chen <cslzchen@gmail.com>
cslzchen
added a commit
that referenced
this pull request
Sep 30, 2025
…-pages Update CAS FE to match angular OSF * [ENG-8793] [ENG-8785] [ENG-8793] Remove branded login + Update no service pages + Update OAuth workflow (#98) * [ENG-8788] [ENG-8786] Institutions page and TOS page redesign (#99) * [ENG-8789] [ENG-8790] [ENG-8791] Exception Page rework (#95) * [ENG-8787] Username/password and 2FA login page (#97) * [ENG-8791] Inserting CasProperties into Spring Dispatcher and Improve header and left pane UI/UX (#92) * [ENG-8927] Add dev mode for forcing errors/exceptions (#93) * [NOTICKET] Remove OSF Collections URL from cas.properties (#91) * [ENG-8556] Update CAS pages to match Angular update: header, footer and left pane (#88) * [ENG-8754] Force throw a few HTTP errors for testing purpose (#90) * [ENG-8792] Force CAS to throw exceptions and display error pages (#87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ENG-8556
Purpose
Changes
Screenshots
Desktop
Mobile
Mobile (Sidenav open)
Dev Notes
OsfUrlProperties.java), or change theth:hrefvalues inleftpane.htmlandheaderosf.htmlQA Notes
Dev-Ops Notes